Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default retry policy is too permissive #417

Open
10 of 15 tasks
rhamzeh opened this issue Sep 19, 2024 · 1 comment · May be fixed by #420
Open
10 of 15 tasks

The default retry policy is too permissive #417

rhamzeh opened this issue Sep 19, 2024 · 1 comment · May be fixed by #420
Assignees
@ovindu-a
Labels
bug Something isn't working dotnet-sdk Affects the C#/DotNet SDK go-sdk Affects the Go SDK good first issue Good for newcomers hacktoberfest java-sdk Affects the Java/Kotlin SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK

Comments

@rhamzeh
Copy link
Member

rhamzeh commented Sep 19, 2024 •
edited
Loading

Checklist

  • I have looked into the README and have not found a suitable solution or answer.
  • I have looked into the documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Slack Community and have not found a suitable solution or answer.
  • I agree to the terms within the OpenFGA Code of Conduct.

Description

We bumped up the default retry (https://github.com/openfga/sdk-generator/blame/1cc4b1b2bc26739e031ae80c7c69da42d0bfb141/config/common/config.base.json#L87) from 5 to 15 last year

The default retry behaviour of 15 retries with exponential backoff is far too aggressive. This means the caller could be sat waiting many minutes for all the retries to complete.

Expectation

It's unexpected for the user for the SDK to be stuck hanging for a while as it retries - by default we should be retrying a few times and failing early.

A more sane default could be 3 retries before giving up

Reproduction

N/A

SDK Checklist

  • JS SDK
  • Go SDK
  • .NET SDK
  • Python SDK
  • Java SDK

OpenFGA SDK version

Latest

OpenFGA version

N/A

SDK Configuration

N/A

Logs

No response

References

Sub-tickets:

  • JS SDK
  • Go SDK
  • .NET SDK
  • Python SDK
  • Java SDK
@rhamzeh rhamzeh added bug Something isn't working good first issue Good for newcomers go-sdk Affects the Go SDK dotnet-sdk Affects the C#/DotNet SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK java-sdk Affects the Java/Kotlin SDK hacktoberfest labels Sep 19, 2024
@rhamzeh rhamzeh moved this from Backlog to Ready in SDKs and Tooling Sep 19, 2024
ovindu-a added a commit to ovindu-a/sdk-generator that referenced this issue Oct 1, 2024
@ovindu-a
fix : change default retry policy (openfga#417)
618ab8e
@ovindu-a ovindu-a linked a pull request Oct 1, 2024 that will close this issue
Open
4 tasks
@ovindu-a
Copy link

ovindu-a commented Oct 1, 2024

Hi @rhamzeh, I have made a pull request for the above issue. Please let me know if there is anything that I must change. Thank you in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ovindu-a ovindu-a

Labels
bug Something isn't working dotnet-sdk Affects the C#/DotNet SDK go-sdk Affects the Go SDK good first issue Good for newcomers hacktoberfest java-sdk Affects the Java/Kotlin SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK
Projects
SDKs and Tooling
Status: Ready
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix : change default retry policy (#417) ovindu-a/sdk-generator
2 participants
@rhamzeh @ovindu-a