Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(python-sdk): fix import order in client and configuration file templates #266

Merged
merged 1 commit into from
Jan 2, 2024
Merged

style(python-sdk): fix import order in client and configuration file templates #266

merged 1 commit into from
Jan 2, 2024

Conversation

tjtanjin
Copy link
Contributor

@tjtanjin tjtanjin commented Dec 29, 2023 •
edited
Loading

Description

  • Fix import order in python/template/client/client.mustache
  • Fix import order in python/template/configuration.mustache

References

Related to #126

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@tjtanjin tjtanjin requested a review from a team as a code owner December 29, 2023 09:00
@tjtanjin tjtanjin changed the title style: fix import order in client and configuration file templates style(python-sdk): fix import order in client and configuration file templates Dec 29, 2023
@tjtanjin tjtanjin mentioned this pull request Dec 29, 2023
Merged
4 tasks
rhamzeh
rhamzeh approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tjtanjin!

@rhamzeh rhamzeh added this pull request to the merge queue Jan 2, 2024
Merged via the queue into openfga:main with commit b8618f3 Jan 2, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjtanjin @rhamzeh