Internationalize scenarios #676
Conversation
|
|
||
| return json_or_python_to_test_case | ||
|
|
||
| def suggest(self): |
There was a problem hiding this comment.
@cbenz @benjello
Does anyone know why we need this, and why it was separated from the rest of the test_case processing ?
It is called when using the api, when running tests, etc. Should it just be part of the normal test_case processing workflow ? Are there cases where you don't want to call this method ?
There was a problem hiding this comment.
I think it was used for th UI. @cbenz should know better
There was a problem hiding this comment.
Yes, suggest was introduced for the UI and could be removed (this would imply to remove a flag in the API code).
why it was separated from the rest of the test_case processing ?
For code clarity I think.
|
|
||
| return json_or_python_to_test_case | ||
|
|
||
| def suggest(self): |
There was a problem hiding this comment.
Yes, suggest was introduced for the UI and could be removed (this would imply to remove a flag in the API code).
why it was separated from the rest of the test_case processing ?
For code clarity I think.
cbenz
force-pushed
the
internationalize-scenarios
branch
from
a687b95
to
6961fc3
Compare
cbenz
force-pushed
the
internationalize-scenarios
branch
from
6961fc3
to
4900ce9
Compare
CHANGELOG.md
Outdated
| @@ -1,6 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
|
|
|||
| ## 14.0.0 | |||
There was a problem hiding this comment.
Je ne pense pas que ce soit un breaking change, si ?
A priori c'est même complètement transparent pour l'utilisateur.
fpagnoux
force-pushed
the
internationalize-scenarios
branch
from
4f56d53
to
2707ad8
Compare
Tu as raison, c'est une erreur. Merci d'avoir modifié. |
Connected to openfisca/openfisca-web-api#76
Apply openfisca/openfisca-core#444 to
france