Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the container image minimal #557

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Keep the container image minimal #557

merged 3 commits into from
Nov 7, 2023

Conversation

sks
Copy link
Contributor

@sks sks commented Nov 3, 2023

Description

  • Changing the base image to be alpine to save on container size
## Before
 ghcr.io/openflagr/flagr              latest    2c7473a02b44   4 months ago     2GB

## After
flagr                               latest    7474e3e001c1   37 minutes ago   68.1MB

Motivation and Context

  • Reducing the container size for faster downloads and better day 1 Experience.

How Has This Been Tested?

  • To be frank, not in big sets, New to flagr, will check on how the github action goes and take necessary steps.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sks sks closed this Nov 3, 2023
@sks
Copy link
Contributor Author

sks commented Nov 3, 2023

Looks like this was already done in #107 and then reverted, will reopen after reading about the history on the reasons

@sks
Copy link
Contributor Author

sks commented Nov 3, 2023

Not sure if this was a miss while merging openflagr , keeping the PR open for now

@sks sks reopened this Nov 3, 2023
@ghost
Copy link

ghost commented Nov 3, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sks sks marked this pull request as ready for review November 3, 2023 17:18
Copy link
Contributor

@nothing0012 nothing0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also change the integration test docker, so that we test the dockerfile change end to end

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #557 (9cf92fb) into main (decc484) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files          28       28           
  Lines        2256     2256           
=======================================
  Hits         1829     1829           
  Misses        337      337           
  Partials       90       90           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@nothing0012 nothing0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@sks
Copy link
Contributor Author

sks commented Nov 6, 2023

Can we merge this ?

@marceloboeira marceloboeira merged commit fcc74ae into openflagr:main Nov 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants