-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the container image minimal #557
Conversation
Looks like this was already done in #107 and then reverted, will reopen after reading about the history on the reasons |
Not sure if this was a miss while merging openflagr , keeping the PR open for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also change the integration test docker, so that we test the dockerfile change end to end
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 28 28
Lines 2256 2256
=======================================
Hits 1829 1829
Misses 337 337
Partials 90 90 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Can we merge this ? |
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: