Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI search by key #561

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

serh11d
Copy link
Contributor

@serh11d serh11d commented Dec 14, 2023

Description

Search by key (UI)

Motivation and Context

When Flagr is additionally used in an isolated environment (local development), the key is used in the code. Accordingly, to quickly gain access to a flag on UI from code, a key is more handy to use. Otherwise code should contain comment with flag ID.

How Has This Been Tested?

Run UI against any environment and paste partially copy of existing key, the item should appear in results.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghost
Copy link

ghost commented Dec 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@nothing0012 nothing0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, a really useful feature

@nothing0012 nothing0012 merged commit 2e3a36b into openflagr:main Jan 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants