Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade gorm to fix unscoped preload #570

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

nothing0012
Copy link
Contributor

Description

Fix #569
This was a regression / bug / feature introduced by go-gorm/gorm#6058

Motivation and Context

How Has This Been Tested?

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghost
Copy link

ghost commented Jan 26, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0c6d78) 81.19% compared to head (f77f498) 81.19%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files          28       28           
  Lines        2271     2271           
=======================================
  Hits         1844     1844           
  Misses        337      337           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nothing0012 nothing0012 merged commit a833b3b into main Jan 26, 2024
9 checks passed
@nothing0012 nothing0012 deleted the zz/revert-gorm-version branch January 26, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flags returned by FindFlags include soft-deleted segments and constraints since 1.1.17
2 participants