Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: separate files for different test cases #128

Closed
wants to merge 4 commits into from
Closed

test: separate files for different test cases #128

wants to merge 4 commits into from

Conversation

sarayusreeyadavpadala
Copy link
Contributor

Hey there! I am a beginner to Open Source and I am interested to contribute to Open Food Facts. Here, I've separated the test cases into different files and deleted the existing file. Let me know if any changes are needed. Looking forward to your suggestions.

@sarayusreeyadavpadala sarayusreeyadavpadala changed the title Off #separate files for different test cases Sep 7, 2023
@sarayusreeyadavpadala sarayusreeyadavpadala changed the title #separate files for different test cases feat: separate files for different test cases Sep 7, 2023
@alexgarel
Copy link
Member

@sarayusreeyadavpadala awesome to see your contributions.

I don't have time to review right now but I will maybe next week (if @aadarsh-ram does not have the time in-between).

@sarayusreeyadavpadala
Copy link
Contributor Author

@alexgarel No problem, take your time.

@sumit-158 sumit-158 changed the title feat: separate files for different test cases tests: separate files for different test cases Sep 8, 2023
Copy link
Member

@sumit-158 sumit-158 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarayusreeyadavpadala Initial comments please use "make lint"

@sumit-158 sumit-158 changed the title tests: separate files for different test cases test: separate files for different test cases Sep 8, 2023
@sarayusreeyadavpadala
Copy link
Contributor Author

@sarayusreeyadavpadala Initial comment please use "make lint"

@sumit-158 Kindly elaborate further on what you have just said.

@aadarsh-ram
Copy link
Contributor

aadarsh-ram commented Sep 8, 2023

Hi @sarayusreeyadavpadala! Thank you for the contributions. Currently, your PR is failing workflows, related to code quality and linting. Please use the make lint command at the root of the repo and commit again. Someone will review your PR soon.

@sarayusreeyadavpadala
Copy link
Contributor Author

Hi @sarayusreeyadavpadala! Thank you for the contributions. Currently, your PR is failing workflows, related to code quality and linting. Please use the make lint command at the root of the repo and commit again. Someone will review your PR soon.

Thank you @aadarsh-ram
I shall attend to that task promptly within the day.

@sarayusreeyadavpadala
Copy link
Contributor Author

@aadarsh-ram, @sumit-158 Could you please check my new commit once....

@sumit-158
Copy link
Member

@sarayusreeyadavpadala Seems like the Linting is not fixed yet :-) , make sure to use make lint. Lets us know if you face any issue 🙂 Please refer this link

@sarayusreeyadavpadala
Copy link
Contributor Author

@sarayusreeyadavpadala Seems like the Linting is not fixed yet :-) , make sure to use make lint. Lets us know if you face any issue 🙂 Please refer this link

Thank you @sumit-158

@sarayusreeyadavpadala
Copy link
Contributor Author

@sarayusreeyadavpadala Seems like the Linting is not fixed yet :-) , make sure to use make lint. Lets us know if you face any issue 🙂 Please refer this link

@sumit-158 when I run "make lint" command, it shows-
docker-compose run --rm --no-deps facets-api isort .
process_begin: CreateProcess(NULL, docker-compose run --rm --no-deps facets-api isort ., ...) failed.
make (e=2): The system cannot find the file specified.
make: *** [Makefile:20: lint] Error 2

@sumit-158
Copy link
Member

@stephanegigandet Can you use Slack for further discussion? Join us in the channel #Knowledge-panel

@sarayusreeyadavpadala
Copy link
Contributor Author

I have sorted the imports using "isort" this time. And also used "black".

@sarayusreeyadavpadala
Copy link
Contributor Author

Could anyone approve the workflows.

Copy link
Member

@sumit-158 sumit-158 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sarayusreeyadavpadala good work, I have made a push for the lint issue, and now it is resolved but tests are failing, please look into it :-)
tip: use docker-compose run --rm --no-deps facets-api pytest -vv . to see the total output of tests and why and where it is failing

@sarayusreeyadavpadala
Copy link
Contributor Author

sarayusreeyadavpadala commented Sep 25, 2023

Hi @sarayusreeyadavpadala good work, I have made a push for the lint issue, and now it is resolved but tests are failing, please look into it :-) tip: use docker-compose run --rm --no-deps facets-api pytest -vv . to see the total output of tests and why and where it is failing

Thank you @sumit-158 I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants