-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update to latest KnowledgePanel API changes #294
Conversation
merge from master
We now create the release with release please, in order for it to add the commit messages to the changelog they need a certain scheme. It would be good if you could add the prefix when merging the PR. After pressing merge you should be able to change the name. It would be either For breaking changes a |
@JsonValue('neutral') | ||
NEUTRAL, | ||
@JsonValue('average') | ||
AVERAGE, | ||
@JsonValue('bad') | ||
BAD, | ||
UNKNOWN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no @JsonValue('unknown') ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more value is "neutral" if I remember correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right: environment/packaging_recycling.tt.json: "evaluation": "neutral",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between "average" and "neutral"? Can't we collapse them into one ?
Unknown: the object gets a value of enum type UNKNOWN when the json parser encounters a value from the server that isn't mappable to anything else in this enum (specifically if server responds with something other than Good, bad, average, the variable is assigned UNKNOWN).
Thanks. @jasmeet0817 please branch off master before working on your changes. This way we can away cluttering the PR with old commits. |
Sure thing |
Co-authored-by: Jasmeet Singh <[email protected]>
No description provided.