Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 919 - new field KnowledgePanelImageElement.link_url #920

Merged
merged 1 commit into from
May 3, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added field link_url to KnowledgePanelImageElement
  • En passant, fixed a tag and generated needed code for an unrelated topic.

Fixes bug(s)

Part of

Impacted files

  • knowledge_panel_element.dart: added the 'link_url' field; fixed the tag for 'alt' field
  • knowledge_panel_element.g.dart: generated
  • user.g.dart: generated - I guess the latest changes in user.dart were not followed by dart run build_runner build

Impacted files:
* `knowledge_panel_element.dart`: added the `'link_url'` field; fixed the tag for `'alt'` field
* `knowledge_panel_element.g.dart`: generated
* `user.g.dart`: generated - I guess the latest changes in `user.dart` were not followed by `dart run build_runner build`
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monsieurtanuki 👍

@teolemon teolemon merged commit a161516 into openfoodfacts:master May 3, 2024
4 of 5 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support field KnowledgePanelImageElement.link_url
2 participants