fix: improve logging (#10434)

* fix(log): add log datetime in log formatter * fix(log): turn log messages into debug in Redis.pm
openfoodfacts · Jun 12, 2024 · 4c9c0b7 · 4c9c0b7
1 parent 6b0da3b
commit 4c9c0b7
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/conf/log.conf b/conf/log.conf
@@ -16,4 +16,4 @@ log4perl.appender.RATELIMITER_LOGFILE=Log::Log4perl::Appender::File
 log4perl.appender.RATELIMITER_LOGFILE.filename=/mnt/podata/logs/ratelimiter_log4perl.log
 log4perl.appender.RATELIMITER_LOGFILE.mode=append
 log4perl.appender.RATELIMITER_LOGFILE.layout=PatternLayout
-log4perl.appender.RATELIMITER_LOGFILE.layout.ConversionPattern=[%d] [%r] %F %L %c %S %m{chomp}%n
+log4perl.appender.RATELIMITER_LOGFILE.layout.ConversionPattern=[%d] %F %L %c %S %m{chomp}%n
diff --git a/conf/minion_log.conf b/conf/minion_log.conf
@@ -7,4 +7,4 @@ log4perl.appender.LOGFILE.filename=/mnt/podata/logs/minion_log4perl.log
 log4perl.appender.LOGFILE.mode=append
 
 log4perl.appender.LOGFILE.layout=PatternLayout
-log4perl.appender.LOGFILE.layout.ConversionPattern=[%r] %F %L %c %S %m{chomp}%n
+log4perl.appender.LOGFILE.layout.ConversionPattern=[%d] %F %L %c %S %m{chomp}%n
diff --git a/conf/off-log.conf b/conf/off-log.conf
@@ -9,18 +9,19 @@ log4perl.appender.LOGFILE.filename=/srv/off/logs/log4perl.log
 log4perl.appender.LOGFILE.mode=append
 
 log4perl.appender.LOGFILE.layout=PatternLayout
-log4perl.appender.LOGFILE.layout.ConversionPattern=[%r] %F %L %c %S %m{chomp}%n
+log4perl.appender.LOGFILE.layout.ConversionPattern=[%d] %F %L %c %S %m{chomp}%n
 
 log4perl.appender.MONGODB_LOGFILE=Log::Log4perl::Appender::File
 log4perl.appender.MONGODB_LOGFILE.filename=/srv/off/logs/mongodb_log4perl.log
 log4perl.appender.MONGODB_LOGFILE.mode=append
 
 log4perl.appender.MONGODB_LOGFILE.layout=PatternLayout
-log4perl.appender.MONGODB_LOGFILE.layout.ConversionPattern=[%r] %F %L %c %S %m{chomp}%n
+log4perl.appender.MONGODB_LOGFILE.layout.ConversionPattern=[%d] %F %L %c %S %m{chomp}%n
 
 log4perl.appender.RATELIMITER_LOGFILE=Log::Log4perl::Appender::File
 log4perl.appender.RATELIMITER_LOGFILE.filename=/srv/off/logs/ratelimiter_log4perl.log
 log4perl.appender.RATELIMITER_LOGFILE.mode=append
 
 log4perl.appender.RATELIMITER_LOGFILE.layout=PatternLayout
 log4perl.appender.RATELIMITER_LOGFILE.layout.ConversionPattern=[%d] %F %L %c %S %m{chomp}%n
+log4perl.appender.RATELIMITER_LOGFILE.layout.ConversionPattern=[%d] %F %L %c %S %m{chomp}%n
diff --git a/conf/off-pro-log.conf b/conf/off-pro-log.conf
@@ -7,4 +7,4 @@ log4perl.appender.LOGFILE.filename=/mnt/off-pro/logs/off-pro/log4perl.log
 log4perl.appender.LOGFILE.mode=append
 
 log4perl.appender.LOGFILE.layout=PatternLayout
-log4perl.appender.LOGFILE.layout.ConversionPattern=[%r] %F %L %c %S %m{chomp}%n
+log4perl.appender.LOGFILE.layout.ConversionPattern=[%d] %F %L %c %S %m{chomp}%n
diff --git a/lib/ProductOpener/Redis.pm b/lib/ProductOpener/Redis.pm
@@ -117,7 +117,7 @@ sub push_to_redis_stream ($user_id, $product_ref, $action, $comment, $diffs) {
 	my $error = "";
 	if (!defined $redis_client) {
 		# we were disconnected, try again
-		$log->info("Trying to reconnect to Redis");
+		$log->debug("Trying to reconnect to Redis") if $log->is_debug();
 		init_redis();
 	}
 	if (defined $redis_client) {
@@ -188,7 +188,7 @@ sub get_rate_limit_user_requests ($ip, $api_action) {
 	my $error = "";
 	if (!defined $redis_client) {
 		# we were disconnected, try again
-		$ratelimiter_log->info("Trying to reconnect to Redis");
+		$ratelimiter_log->debug("Trying to reconnect to Redis") if $ratelimiter_log->is_debug();
 		init_redis();
 	}
 	my $resp;
@@ -254,7 +254,7 @@ sub increment_rate_limit_requests ($ip, $api_action) {
 	my $error = "";
 	if (!defined $redis_client) {
 		# we were disconnected, try again
-		$ratelimiter_log->info("Trying to reconnect to Redis");
+		$ratelimiter_log->debug("Trying to reconnect to Redis") if $ratelimiter_log->is_debug();
 		init_redis();
 	}
 	if (defined $redis_client) {