feat: Packaging add Czech #10351
Merged
feat: Packaging add Czech #10351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbenben2
added
📍🏭 Packager codes
|
|
If it is fine for you @alexgarel and @stephanegigandet, I suggest bypassing the code complexity alert of Sonar Cloud for Czech (also - to come in future PR - for Denmark, Hungary). In future works, starting with Ireland, I will make changes (different API, handling everything automatically (without manual task) and following Sonar Cloud recommendations. |
benbenben2
added a commit
that referenced
this pull request
Jul 16, 2024
### What packaging codes adds Ireland ### Screenshot  ### Related issue(s) and discussion Part of #338 More examples: #8921, #8958, #10264, #10318, #10351, #10388, #10485: - lib/ProductOpener/Display.pm add description (name, street, city) based on columns in the file or hardcoded - lib/ProductOpener/PackagerCodes.pm add country and suffix of the code - scripts/update_packager_codes.pl add code formatting ('country' 'code' 'suffix', for example if code does not already contain 'country' or 'suffix') add the column name for the $code variable - packager-codes/ add the csv file (mind the naming) - scripts/packager-codes/ add your script - update sto files ``` docker exec -it po_off-backend-1 bash ./scripts/update_packager_codes.pl ``` Based on the experience acquired in previous PR, I did the following changes: -> switch from geocode to nominatim (+ no need of API key, +/- exactly same results) -> reintroduced cache (introduced for Slovenija, #10124, and not used afterward) -> handled whole process without manual intervention (to fetch files, _etc_.), using Excel to dataframe feature from polars and using beautiful soup, not sure that this will be possible to do the same for future countries but at least for that one it was successful. Fixes: #1572
john-gom
pushed a commit
to 4nt0ineB/openfoodfacts-server
that referenced
this pull request
Jul 19, 2024
### What packaging codes adds Ireland ### Screenshot  ### Related issue(s) and discussion Part of openfoodfacts#338 More examples: openfoodfacts#8921, openfoodfacts#8958, openfoodfacts#10264, openfoodfacts#10318, openfoodfacts#10351, openfoodfacts#10388, openfoodfacts#10485: - lib/ProductOpener/Display.pm add description (name, street, city) based on columns in the file or hardcoded - lib/ProductOpener/PackagerCodes.pm add country and suffix of the code - scripts/update_packager_codes.pl add code formatting ('country' 'code' 'suffix', for example if code does not already contain 'country' or 'suffix') add the column name for the $code variable - packager-codes/ add the csv file (mind the naming) - scripts/packager-codes/ add your script - update sto files ``` docker exec -it po_off-backend-1 bash ./scripts/update_packager_codes.pl ``` Based on the experience acquired in previous PR, I did the following changes: -> switch from geocode to nominatim (+ no need of API key, +/- exactly same results) -> reintroduced cache (introduced for Slovenija, openfoodfacts#10124, and not used afterward) -> handled whole process without manual intervention (to fetch files, _etc_.), using Excel to dataframe feature from polars and using beautiful soup, not sure that this will be possible to do the same for future countries but at least for that one it was successful. Fixes: openfoodfacts#1572
benbenben2
added a commit
that referenced
this pull request
Jul 25, 2024
### What packaging codes adds Luxembourg ### Screenshot BEFORE -> AFTER  ### Related issue(s) and discussion Part of #338 More examples: #8921, #8958, #10264, #10318, #10351, #10388, #10485, #10533: - lib/ProductOpener/Display.pm add description (name, street, city) based on columns in the file or hardcoded - lib/ProductOpener/PackagerCodes.pm add country and suffix of the code - scripts/update_packager_codes.pl add code formatting ('country' 'code' 'suffix', for example if code does not already contain 'country' or 'suffix') add the column name for the $code variable - packager-codes/ add the csv file (mind the naming) - scripts/packager-codes/ add your script - update sto files ``` docker exec -it po_off-backend-1 bash ./scripts/update_packager_codes.pl ``` Fixes: #331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
packaging codes add Czech
Screenshot
Related issue(s) and discussion
Part of #338
More details based on previous work (#8921, #8958, #10264, #10318):
add description (name, street, city) based on columns in the file or hardcoded
add country and suffix of the code
add code formatting ('country' 'code' 'suffix', for example if code does not already contain 'country' or 'suffix')
add the column name for the $code variable
add the csv file (mind the naming)
add your script (remove api keys if any)