Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load packaging codes for Ireland #1572

Closed
MaximeLaurenty opened this issue Dec 12, 2018 · 4 comments · Fixed by #10533 or #10529
Closed

Load packaging codes for Ireland #1572

MaximeLaurenty opened this issue Dec 12, 2018 · 4 comments · Fixed by #10533 or #10529
Assignees
@benbenben2
Labels
🇮🇪 Ireland 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near-

Comments

@MaximeLaurenty
Copy link
Contributor

MaximeLaurenty commented Dec 12, 2018 •
edited by teolemon
Loading

Claimed by @MaximeLaurenty

Part of
@MaximeLaurenty
Copy link
Contributor Author

MaximeLaurenty commented Dec 12, 2018 •
edited
Loading

A file with all datas available online and packager codes:
https://www.dropbox.com/s/u83sx5r0jld9ep2/Ireland_concatenated_ALL_2.csv?dl=0
A file with only the datas from the script I wrote (does not handle everything included in the one above, the difference is the 2 excel files that can be found on one ministry website)
https://www.dropbox.com/s/y6nqr4mfbblsb09/Ireland_concatenated.csv?dl=0

@MaximeLaurenty
Copy link
Contributor Author

MaximeLaurenty commented Dec 12, 2018 •
edited
Loading

I've pulled the script in the adequate place here :
0c0c904

@MaximeLaurenty
Copy link
Contributor Author

@teolemon please add this to the Trello as well (https://github.com/openfoodfacts/openfoodfacts-carbonfootprint/projects/1)

@MaximeLaurenty
Copy link
Contributor Author

@teolemon ping.
Could you push this further ?

@teolemon teolemon added the 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near- label Jun 11, 2019
@teolemon teolemon mentioned this issue Aug 20, 2021
Open
@benbenben2 benbenben2 self-assigned this May 30, 2024
@benbenben2 benbenben2 mentioned this issue Jul 10, 2024
Merged
benbenben2 added a commit that referenced this issue Jul 16, 2024
@benbenben2
feat: packaging add Ireland (#10533)
3f3196e 
### What
packaging codes adds Ireland

### Screenshot

![Screenshot_20240710_173536](https://github.com/openfoodfacts/openfoodfacts-server/assets/110821832/e0eb280e-5018-4daa-be72-cf0e48256762)

### Related issue(s) and discussion
Part of #338

More examples: #8921, #8958, #10264, #10318, #10351, #10388, #10485:
- lib/ProductOpener/Display.pm
add description (name, street, city) based on columns in the file or
hardcoded
- lib/ProductOpener/PackagerCodes.pm
add country and suffix of the code
- scripts/update_packager_codes.pl
add code formatting ('country' 'code' 'suffix', for example if code does
not already contain 'country' or 'suffix')
add the column name for the $code variable
- packager-codes/
add the csv file (mind the naming)
- scripts/packager-codes/
add your script
- update sto files
```
docker exec -it po_off-backend-1 bash
./scripts/update_packager_codes.pl
```

Based on the experience acquired in previous PR, I did the following
changes:
-> switch from geocode to nominatim (+ no need of API key, +/- exactly
same results)
-> reintroduced cache (introduced for Slovenija, #10124, and not used
afterward)
-> handled whole process without manual intervention (to fetch files,
_etc_.), using Excel to dataframe feature from polars and using
beautiful soup, not sure that this will be possible to do the same for
future countries but at least for that one it was successful.

Fixes: #1572
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Jul 16, 2024
Merged
john-gom pushed a commit to 4nt0ineB/openfoodfacts-server that referenced this issue Jul 19, 2024
@benbenben2 @john-gom
feat: packaging add Ireland (openfoodfacts#10533)
4bcda3d 
### What
packaging codes adds Ireland

### Screenshot

![Screenshot_20240710_173536](https://github.com/openfoodfacts/openfoodfacts-server/assets/110821832/e0eb280e-5018-4daa-be72-cf0e48256762)

### Related issue(s) and discussion
Part of openfoodfacts#338

More examples: openfoodfacts#8921, openfoodfacts#8958, openfoodfacts#10264, openfoodfacts#10318, openfoodfacts#10351, openfoodfacts#10388, openfoodfacts#10485:
- lib/ProductOpener/Display.pm
add description (name, street, city) based on columns in the file or
hardcoded
- lib/ProductOpener/PackagerCodes.pm
add country and suffix of the code
- scripts/update_packager_codes.pl
add code formatting ('country' 'code' 'suffix', for example if code does
not already contain 'country' or 'suffix')
add the column name for the $code variable
- packager-codes/
add the csv file (mind the naming)
- scripts/packager-codes/
add your script
- update sto files
```
docker exec -it po_off-backend-1 bash
./scripts/update_packager_codes.pl
```

Based on the experience acquired in previous PR, I did the following
changes:
-> switch from geocode to nominatim (+ no need of API key, +/- exactly
same results)
-> reintroduced cache (introduced for Slovenija, openfoodfacts#10124, and not used
afterward)
-> handled whole process without manual intervention (to fetch files,
_etc_.), using Excel to dataframe feature from polars and using
beautiful soup, not sure that this will be possible to do the same for
future countries but at least for that one it was successful.

Fixes: openfoodfacts#1572
stephanegigandet pushed a commit that referenced this issue Jul 23, 2024
@openfoodfacts-bot
chore(main): release 2.38.0 (#10529)
1e6623e 
🤖 I have created a release *beep* *boop*
---


##
[2.38.0](v2.37.0...v2.38.0)
(2024-07-23)


### Features

* add new product event types for redis queue
([#10530](#10530))
([339dbc4](339dbc4))
* add product data to org table
([#10534](#10534))
([dce0518](dce0518))
* added a drag and drop zone in pro platform
([#10569](#10569))
([ce60b8f](ce60b8f))
* allow orgs to not have a main contact if imported from an aggregator
([#10531](#10531))
([ead1b0c](ead1b0c))
* launch the exports for all organizations that have the checkbox…
([#10561](#10561))
([c3aa2d1](c3aa2d1))
* Lint spaces in taxonomies
([#10563](#10563))
([c01cf91](c01cf91))
* make valid org filter field a dropdown
([#10524](#10524))
([b38e62c](b38e62c))
* measure and log duration of request and mongodb / off-query que…
([#10557](#10557))
([2cb1b1e](2cb1b1e))
* packaging add Ireland
([#10533](#10533))
([3f3196e](3f3196e)),
closes
[#1572](#1572)


### Bug Fixes

* add product_type to redis events
([#10550](#10550))
([6bd1c0e](6bd1c0e))
* added barcode-svg
([#10242](#10242))
([8da89da](8da89da))
* broken user space on pro platform
([#10541](#10541))
([b6e3017](b6e3017))
* change_main_contact.pl
([#10548](#10548))
([b2f90ea](b2f90ea))
* disable caching on pro platform
([#10516](#10516))
([4ccd714](4ccd714))
* GDSN import from Alnatura
([#10556](#10556))
([6e2673a](6e2673a))
* improve generated data for a .pl script
([#10532](#10532))
([1cab04c](1cab04c))
* pro_moderator_owner not stored for the admin/moderator user through
org/[orgid] facet
([#10560](#10560))
([e0441c6](e0441c6))
* rate limiter log config
([#10535](#10535))
([9a5168d](9a5168d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbenben2 benbenben2

Labels
🇮🇪 Ireland 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near-
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
3 participants
@teolemon @MaximeLaurenty @benbenben2