Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevention - Nutrition - Ignore nutrition values if salt is the only value passed and it is 0 #1759

Open
2 tasks
Tracked by #10272
stephanegigandet opened this issue May 8, 2019 · 7 comments
Labels
🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality Fixed ? This issue might have been fixed. We can close them once we verify that they have. Nutrition facts

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented May 8, 2019

What

Yuka has been sending almost empty nutrition facts, with just 0 for salt. (currently 3500 products): https://world.openfoodfacts.org/quality/nutrition-only-has-zero-salt-and-sodium

  • Create a rule to ignore salt if it's the only value passed and it is 0.
  • Use a script to update existing products.

Part of

@teolemon teolemon added 🐛 bug This is a bug, not a feature request. Nutrition facts 🧽 Data quality https://wiki.openfoodfacts.org/Quality labels Jun 11, 2019
@hangy
Copy link
Member

hangy commented Jun 21, 2019

Is this still an issue? The quality facet only lists one product now, and that in fact looks good.

@CharlesNepote CharlesNepote added the Fixed ? This issue might have been fixed. We can close them once we verify that they have. label Jun 21, 2019
@teolemon
Copy link
Member

@stephanegigandet There's no product left. Can we close ?

@teolemon teolemon changed the title Ignore nutrition values if salt is the only value passed and it is 0 Prevention - Ignore nutrition values if salt is the only value passed and it is 0 Oct 11, 2021
@teolemon teolemon changed the title Prevention - Ignore nutrition values if salt is the only value passed and it is 0 Prevention - Nutrition - Ignore nutrition values if salt is the only value passed and it is 0 Oct 11, 2021
@benbenben2
Copy link
Collaborator

Related to
#1564

If it is not needed any more, we could close this.
Alternatively, we could generalize it for 1 or more nutrition element having 0 and all others being empty. But if it is not needed, we could simply close it...

Also, there is already facet for 3 times same values and above 1 (#8109)

@benbenben2
Copy link
Collaborator

@stephanegigandet @CharlesNepote
There are 15961 products in this case: mirabelle

Is this still what you want to do?

  • Create a rule to ignore salt if it's the only value passed and it is 0.
  • Use a script to update existing products.

@stephanegigandet
Copy link
Contributor Author

We could review the products, to see if there are any false positives, but I can't think of how a product would list only salt: 0

@benbenben2
Copy link
Collaborator

This may be extended to any major nutrient being zero and all others undefined: mirabelle

-- 17 rows for "energy-kj_100g"="0"
-- 2908 rows for "energy-kcal_100g"="0"
-- 21 rows fat_100g="0"
-- 2555 "saturated-fat_100g"="0"
-- 3 carbohydrates_100g="0"
-- 11 sugars_100g="0"
-- 3 proteins_100g="0"

@aleene
Copy link
Contributor

aleene commented Dec 6, 2023

We could run a script to remove these values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality Fixed ? This issue might have been fixed. We can close them once we verify that they have. Nutrition facts
Projects
Status: To discuss and validate
Status: To do
Development

Successfully merging a pull request may close this issue.

6 participants