Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: data quality warning for 3 identical values in nutrition tables #8109

Merged
merged 9 commits into from
Feb 24, 2023
Merged

feat: data quality warning for 3 identical values in nutrition tables #8109

merged 9 commits into from
Feb 24, 2023

Conversation

benbenben2
Copy link
Collaborator

Resolve #3554

Data quality warning for 3 identical values and values above 1 in nutrition tables for major nutrients.

make lint
make checks
make cover

are done and passed

Ping @CharlesNepote to review taxonomy for data quality in this PR as well.

@benbenben2 benbenben2 added 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data labels Feb 15, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner February 15, 2023 19:12
@benbenben2 benbenben2 self-assigned this Feb 15, 2023
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests 💥 Merge Conflicts 💥 Merge Conflicts labels Feb 15, 2023
adilwahla
adilwahla approved these changes Feb 16, 2023
View reviewed changes
Copy link

@adilwahla adilwahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Feb 16, 2023
@github-actions github-actions bot added the 📚 Documentation Documentation issues improve the project for everyone. label Feb 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #8109 (cb9497f) into main (dad4a8d) will increase coverage by 0.05%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main    #8109      +/-   ##
==========================================
+ Coverage   45.42%   45.48%   +0.05%     
==========================================
  Files         102      102              
  Lines       20230    20248      +18     
  Branches     4628     4631       +3     
==========================================
+ Hits         9189     9209      +20     
+ Misses       9943     9942       -1     
+ Partials     1098     1097       -1
Impacted Files Coverage Δ
lib/ProductOpener/DataQualityFood.pm 59.18% <92.85%> (+1.92%) ⬆️
tests/unit/dataqualityfood.t 78.35% <100.00%> (+1.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

stephanegigandet
stephanegigandet approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Feb 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2 benbenben2 merged commit 70a4926 into main Feb 24, 2023
@benbenben2 benbenben2 deleted the feat_add_quality_facet_nutrition_3_or_more_values_are_identical branch February 24, 2023 22:08
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Feb 24, 2023
Merged
@benbenben2 benbenben2 mentioned this pull request May 12, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

@adilwahla adilwahla adilwahla approved these changes

Assignees

@benbenben2 benbenben2

Labels
🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality https://wiki.openfoodfacts.org/Quality 📚 Documentation Documentation issues improve the project for everyone. 💥 Merge Conflicts 💥 Merge Conflicts 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quality facet - Nutrition - Flag products where 3 or more nutritional values are identical
4 participants
@benbenben2 @codecov-commenter @stephanegigandet @adilwahla