Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add include_root_entries option to taxonomy API, fixes #6039 #6040

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Oct 29, 2021

Requested by @gspencergoog for the category picker in the Flutter app.

e.g. https://world.openfoodfacts.dev/api/v2/taxonomy?tagtype=packaging_materials&tags=en:plastic&include_root_entries=1

For categories: https://world.openfoodfacts.dev/api/v2/taxonomy?tagtype=categories&include_root_entries=1

Note: we have many entries without parents that probably should have one.

@stephanegigandet stephanegigandet added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Oct 29, 2021
@stephanegigandet stephanegigandet requested a review from a team as a code owner October 29, 2021 18:18
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanegigandet stephanegigandet merged commit 7bcbcb7 into main Oct 29, 2021
@stephanegigandet stephanegigandet deleted the include_root_entries branch October 29, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants