Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW DESIGN - The arrow is not centered in Manage image button #7489

Closed
1 task
Tracked by #7295
teolemon opened this issue Oct 11, 2022 · 5 comments · Fixed by #9135 or #9136
Closed
1 task
Tracked by #7295

NEW DESIGN - The arrow is not centered in Manage image button #7489

teolemon opened this issue Oct 11, 2022 · 5 comments · Fixed by #9135 or #9136
Assignees
@TCatinaud
Labels
🐛 bug This is a bug, not a feature request. CSS 🎨 Design ✏️ Editing good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 🎨 Needs design 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign.

Comments

@teolemon
Copy link
Member

What

  • The arrow is not centered in Manage image button

Screenshot

image

Part of
@teolemon teolemon added 🐛 bug This is a bug, not a feature request. ✏️ Editing 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. labels Oct 11, 2022
@teolemon teolemon mentioned this issue Oct 11, 2022
Open
@teolemon teolemon added good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. CSS labels Oct 11, 2022
@teolemon
Copy link
Member Author

@teolemon : mockup with chevron on the bottom (middle)

@dhruv1345
Copy link

@alexgarel, @yuktea If this issue is open, Please assign it to me.

@alexgarel
Copy link
Member

I think it's a matter of CSS (see _off.scss)

IF you need to touch the html, rendering of knowledge panels happens in panel.tt.html.

@stephanegigandet
Copy link
Contributor

Note that this arrow is used on all expandable knowledge panels, it might look weird if it is vertically centered on panels that have a taller heading, such as the Nutri-Score panel:

image

@TCatinaud
Copy link
Collaborator

@raphael0202, Could you please assign the issue to me?

TCatinaud added a commit that referenced this issue Oct 11, 2023
@TCatinaud
fix: arrow is not centered in Manage image button Fixes #7489
02adb7c
@TCatinaud TCatinaud mentioned this issue Oct 11, 2023
Merged
stephanegigandet pushed a commit that referenced this issue Oct 11, 2023
@TCatinaud
fix: arrow is not centered in Manage image button Fixes #7489 (#9135)
8d1615c
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TCatinaud TCatinaud

Labels
🐛 bug This is a bug, not a feature request. CSS 🎨 Design ✏️ Editing good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 🎨 Needs design 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign.
Projects
Getting the new web design to the next level
Archived in project
Milestone
No milestone
5 participants
@alexgarel @teolemon @TCatinaud @stephanegigandet @dhruv1345