Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sulfates and nitrates are not in the nutrients' list #8265

Closed
CharlesNepote opened this issue Mar 29, 2023 · 2 comments · Fixed by #8412
Closed

Sulfates and nitrates are not in the nutrients' list #8265

CharlesNepote opened this issue Mar 29, 2023 · 2 comments · Fixed by #8412
Labels
🐛 bug This is a bug, not a feature request. ⭐ 🐛 top bug Top bug.

Comments

@CharlesNepote
Copy link
Member

CharlesNepote commented Mar 29, 2023

Describe the bug

Most (the majority?) of the waters do display sulfates' quantity, and sometimes Nitrates, in the nutrients' table. Eg.

To Reproduce

Edit https://world.openfoodfacts.org/product/8437019482329/aqua-sierra-nevada and try to add Sulfates.

Expected behavior

The display-as-you-type should provide Sulfates with mg unit (alternative English spelling sulphate (UK)).

I guess it should be in the singular form: Sulfate, Nitrate.

The field should also be exported in the daily CSV exports.

Screenshots

No response

Additional context

No response

Type of device

Browser

Browser version

No response

Number of products impacted

No response

Time per product

No response

@CharlesNepote CharlesNepote added the 🐛 bug This is a bug, not a feature request. label Mar 29, 2023
@CharlesNepote CharlesNepote changed the title Sulfates is not in the nutrients' list Sulfates and nitrates are not in the nutrients' list Mar 29, 2023
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label Apr 5, 2023
@benbenben2
Copy link
Collaborator

See following PR: #8323

The field should also be exported in the daily CSV exports.

Is this related to the nutriments_tables subroutine called in Export.pm and defined in Food.pm?

@aleene
Copy link
Contributor

aleene commented Apr 15, 2023

There is a file somewhere where is defined which nutrients are exposed to the user. Have to look it up. These ones are indeed needed for mineral waters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. ⭐ 🐛 top bug Top bug.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants