Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: added some nutrients #8323

Merged
merged 4 commits into from
May 9, 2023
Merged

taxonomy: added some nutrients #8323

merged 4 commits into from
May 9, 2023

Conversation

benbenben2
Copy link
Collaborator

Related to: #8265
Related to: #8241

That would invalidate/replace this branch: https://github.com/openfoodfacts/openfoodfacts-server/tree/allulose

@benbenben2 benbenben2 self-assigned this Apr 14, 2023
@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Apr 14, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner April 15, 2023 14:49
@benbenben2
Copy link
Collaborator Author

Sorry. Did not find the way to solve errors. Any help is welcome

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #8323 (5313181) into main (e70a705) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8323   +/-   ##
=======================================
  Coverage   48.44%   48.44%           
=======================================
  Files         113      113           
  Lines       21251    21251           
  Branches     4767     4767           
=======================================
  Hits        10296    10296           
  Misses       9674     9674           
  Partials     1281     1281           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benbenben2
Copy link
Collaborator Author

@stephanegigandet, @alexgarel, if there is a documentation to update_tests_results, feel free to add the following:

update_tests_results

If you encounter errors in Unit Test Coverage > Generate Coverage results or in Perl Unit Tests > Perl Unit Tests that are similar to this:

2023-04-21T20:57:43.0821875Z #          $got->{value-chromium-serving} = HASH(0x55e07fc2f720)
2023-04-21T20:57:43.0822409Z #     $expected->{value-chromium-serving} = Does not exist
...
2023-04-21T20:58:19.9821084Z #          $got->{fibres-alimentaires-solubles-plat-valeur} = HASH(0x55e09daca0d8)
2023-04-21T20:58:19.9821650Z #     $expected->{fibres-alimentaires-solubles-plat-valeur} = Does not exist
...
2023-04-21T20:59:19.8309256Z #          $got->{unidad-acido-mead-preparado} = HASH(0x55e090362bd8)
2023-04-21T20:59:19.8309480Z #     $expected->{unidad-acido-mead-preparado} = Does not exist

  • temporarily update tests/update_tests_results.sh to have only the test file that has errors (producers.t in this example, you can find it easily in the logs because tests are done one by one in alphabetical orders). That way you will update only concerned files.
  • delete all hidden files in taxonomies (if any), such as nutrients.results.sto or nutrients.results.txt.
  • delete the expected tests results (tests/unit/expected_test_results/producers/column_names_*.json, in this example)
  • run make update_tests_results
  • cancel changes in update tests/update_tests_results.sh
  • add, commit and push

@stephanegigandet
Copy link
Contributor

@benbenben2 I will remove those tests, they are not very useful and they take a lot of space. I think I removed them in this PR: #8351

@benbenben2
Copy link
Collaborator Author

@benbenben2 I will remove those tests, they are not very useful and they take a lot of space. I think I removed them in this PR: #8351

I rolled back to previous commit (before to try to recreate tests)

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2 benbenben2 merged commit bea641d into main May 9, 2023
@benbenben2 benbenben2 deleted the taxonomy_add_nutrients branch May 9, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants