taxonomy: Lithuanian ingredients + processing

[DanieliusAsm]

What

Retrying because large conflicts in #9075

Plus adding ingredients_processing

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: Leftover TODOs in the code should be handled.
• Apply: All new business logic should have corresponding unit tests in the tests/ directory.
• Apply: Any clearly inefficient or repeated code should be optimized or refactored.

[codecov-commenter]

Codecov Report

Merging #9148 (91738b6) into main (118f9b9) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 70.83%.

@@           Coverage Diff           @@
##             main    #9148   +/-   ##
=======================================
  Coverage   47.98%   47.98%           
=======================================
  Files          64       64           
  Lines       20068    20084   +16     
  Branches     4870     4875    +5     
=======================================
+ Hits         9629     9638    +9     
- Misses       9185     9188    +3     
- Partials     1254     1258    +4     

Files	Coverage Δ
lib/ProductOpener/FoodGroups.pm	67.92% <100.00%> (ø)
lib/ProductOpener/Ingredients.pm	92.44% <ø> (ø)
lib/ProductOpener/Tags.pm	41.64% <100.00%> (+0.03%)	⬆️
lib/ProductOpener/Food.pm	70.83% <66.66%> (-0.09%)	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[benbenben2]

is it synonym of Krakmolas or could it be synonym of "Modifikuotas krakmolas" in additives.txt?

[DanieliusAsm]

tirštiklis means thickener. In one of the product's ingredients it was listed "tirštiklis krakmolas". "tirštiklis" should probably be somewhere else not sure where.

[benbenben2]

me neither. Let's leave it in ingredients.txt for now.

[benbenben2]

For "lt:regeneruotas nugriebtas pienas", you can
1/ add "lt:regeneruotas" under "en:reconstituted" in ingredients_processing.txt
2/ make sure that "nugriebtas pienas" is in ingredients.txt (this is the case, under "en:skimmed milk") and
3/ add "lt" in the processing parsing in Ingredients.pm (this is under "# Try to remove ingredients processing "cooked rice" -> "rice", you have 3 possibilities:

• a) # match before or after the ingredient, require a space,
• b) # match before or after the ingredient, does not require a space,
• c) # match after the ingredient, does not require a space + # match before the ingredient, require a space,

I think "lt" would be a)

"en:watermelon juice" , "lt:arbūzų sulčių koncentratas" would not be needed after these feat

It will be a benefit for you because not only "arbūzų sulčių koncentratas", for example will be recognized but all ingredients like "something sulčių koncentratas" as long as "something" is in the taxonomy already.

[DanieliusAsm]

@benbenben2

1. Done
2. Already is
3. I think I added it (First time in Ingredients.pm) not sure if thats it.

Shouldn't then "arbūzų" be also in ingredients_processing just like with reconstituted example ? and then "sulčių koncentratas" in ingredients.txt ? But then I need to add all kinds of possibilities for juice concentrates: Banana, orange, apple etc.

Or does it work if I have in ingredients.txt: "en:watermelon" and "en:concentrated juice" defined ?

[benbenben2]

Because there is "nugriebtas pienas" in ingredients.txt and "regeneruotas" in ingredients_processing.txt, this line becomes useless. We can keep it as comment, to help find ingredients with processing in ingredients.txt for when we will tackle more languages for processing.

Suggested change

	lt:regeneruotas nugriebtas pienas
	# lt:regeneruotas nugriebtas pienas # see ingredients_processing.txt

[benbenben2]

Shouldn't then "arbūzų" be also in ingredients_processing just like with reconstituted example ? and then "sulčių koncentratas" in ingredients.txt ? But then I need to add all kinds of possibilities for juice concentrates: Banana, orange, apple etc.

Or does it work if I have in ingredients.txt: "en:watermelon" and "en:concentrated juice" defined ?

It works if you have in ingredients.txt: "en:watermelon" and in ingredients_processing.txt "en:concentrated juice" defined.

[benbenben2]

For the failing tests, you have to run "make lint" locally.

[alexgarel]

I added the lint commit and resolved conflict.

@benbenben2 is this ready to merge (if tests pass ?)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[benbenben2]

Good job @DanieliusAsm!

[benbenben2]

Thanks @alexgarel