-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Lithuanian ingredients + processing #9148
Conversation
Apply Sweep Rules to your PR?
|
Codecov Report
@@ Coverage Diff @@
## main #9148 +/- ##
=======================================
Coverage 47.98% 47.98%
=======================================
Files 64 64
Lines 20068 20084 +16
Branches 4870 4875 +5
=======================================
+ Hits 9629 9638 +9
- Misses 9185 9188 +3
- Partials 1254 1258 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -13774,7 +13780,7 @@ kk:Крахмал | |||
ko:녹말 | |||
la:Amylum | |||
li:Zètmael | |||
lt:Krakmolas | |||
lt:Krakmolas, tirštiklis krakmolas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it synonym of Krakmolas or could it be synonym of "Modifikuotas krakmolas" in additives.txt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tirštiklis means thickener. In one of the product's ingredients it was listed "tirštiklis krakmolas". "tirštiklis" should probably be somewhere else not sure where.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me neither. Let's leave it in ingredients.txt for now.
For "lt:regeneruotas nugriebtas pienas", you can
I think "lt" would be a) "en:watermelon juice" , "lt:arbūzų sulčių koncentratas" would not be needed after these feat It will be a benefit for you because not only "arbūzų sulčių koncentratas", for example will be recognized but all ingredients like "something sulčių koncentratas" as long as "something" is in the taxonomy already. |
Shouldn't then "arbūzų" be also in ingredients_processing just like with reconstituted example ? and then "sulčių koncentratas" in ingredients.txt ? But then I need to add all kinds of possibilities for juice concentrates: Banana, orange, apple etc. Or does it work if I have in ingredients.txt: "en:watermelon" and "en:concentrated juice" defined ? |
@@ -4034,6 +4035,7 @@ fr:lait écrémé réhydraté | |||
# hr:rekonstituirano obrano mlijeko # see ingredients_processing.txt | |||
hu:visszaállított sovány tej, feloldott sovány tej | |||
it:latte scremato reidratato | |||
lt:regeneruotas nugriebtas pienas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there is "nugriebtas pienas" in ingredients.txt and "regeneruotas" in ingredients_processing.txt, this line becomes useless. We can keep it as comment, to help find ingredients with processing in ingredients.txt for when we will tackle more languages for processing.
lt:regeneruotas nugriebtas pienas | |
# lt:regeneruotas nugriebtas pienas # see ingredients_processing.txt |
It works if you have in ingredients.txt: "en:watermelon" and in ingredients_processing.txt "en:concentrated juice" defined. |
For the failing tests, you have to run "make lint" locally. |
I added the lint commit and resolved conflict. @benbenben2 is this ready to merge (if tests pass ?) |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @DanieliusAsm!
Thanks @alexgarel |
What
Retrying because large conflicts in #9075
Plus adding ingredients_processing