fix: existing orgs migration script to crm #10727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-migration-script
github-actions
bot
added
🏭 Producers Platform
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10727 +/- ##
==========================================
- Coverage 49.54% 49.23% -0.32%
==========================================
Files 67 77 +10
Lines 20650 22064 +1414
Branches 4980 5269 +289
==========================================
+ Hits 10231 10863 +632
- Misses 9131 9875 +744
- Partials 1288 1326 +38 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
Template::Toolkit
| } | ||
|
|
||
| my $org_is_valid = exists $orgs_to_accept{$org_id}; | ||
| if ($org_is_valid) { | ||
| $org_ref->{valid_org} = 'accepted'; | ||
| sync_org_with_crm($org_ref, $User_id); |
There was a problem hiding this comment.
So when we ran the script on Friday on the first orgs, some were accepted, but not synced in the crm?
|
stephanegigandet
pushed a commit
that referenced
this pull request
Aug 28, 2024
🤖 I have created a release *beep* *boop* --- ## [2.43.0](v2.42.0...v2.43.0) (2024-08-28) ### Features * add rate-limiting on facet pages ([#10738](#10738)) ([9e9e321](9e9e321)) ### Bug Fixes * ban more AI bots in robots.txt ([#10726](#10726)) ([4ce657e](4ce657e)) * existing orgs migration script to crm ([#10727](#10727)) ([1e255d4](1e255d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed a bunch of things in the sync process in CRM.pm.
Also, in migration script :