-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: existing orgs migration script to crm #10727
fix: existing orgs migration script to crm #10727
Conversation
…ix-migration-script
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10727 +/- ##
==========================================
- Coverage 49.54% 49.23% -0.32%
==========================================
Files 67 77 +10
Lines 20650 22064 +1414
Branches 4980 5269 +289
==========================================
+ Hits 10231 10863 +632
- Misses 9131 9875 +744
- Partials 1288 1326 +38 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
} | ||
|
||
my $org_is_valid = exists $orgs_to_accept{$org_id}; | ||
if ($org_is_valid) { | ||
$org_ref->{valid_org} = 'accepted'; | ||
sync_org_with_crm($org_ref, $User_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So when we ran the script on Friday on the first orgs, some were accepted, but not synced in the crm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes exactly
Quality Gate passedIssues Measures |
🤖 I have created a release *beep* *boop* --- ## [2.43.0](v2.42.0...v2.43.0) (2024-08-28) ### Features * add rate-limiting on facet pages ([#10738](#10738)) ([9e9e321](9e9e321)) ### Bug Fixes * ban more AI bots in robots.txt ([#10726](#10726)) ([4ce657e](4ce657e)) * existing orgs migration script to crm ([#10727](#10727)) ([1e255d4](1e255d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
What
Fixed a bunch of things in the sync process in CRM.pm.
Also, in migration script :