Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow CORS requests for product image move #10920

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Oct 21, 2024

It's required by Nutripatrol to perform image deletion from nutripatrol.openfoodfacts.org
@Valimp FYI

It's required by Nutripatrol to perform image deletion from
nutripatrol.openfoodfacts.org
Copy link

sonarcloud bot commented Oct 21, 2024

@stephanegigandet
Copy link
Contributor

@raphael0202 looks good, but it would be good to add an integration test to make sure we don't break it in the future

@raphael0202
Copy link
Contributor Author

I looked into integration tests, but I think it will take me quite some times to get it right. I'm merging it for now.

@raphael0202 raphael0202 merged commit 967a47e into main Oct 22, 2024
14 checks passed
@raphael0202 raphael0202 deleted the allow-cross-domain-request-product-image-move branch October 22, 2024 12:21
stephanegigandet pushed a commit that referenced this pull request Oct 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.47.0](v2.46.0...v2.47.0)
(2024-10-24)


### Features

* api docs remove query string from get by barcode and add security to
solve openapi linter errors/warnings
([#10922](#10922))
([b7aefbd](b7aefbd))
* Eco-Score improvements and change of scale: A+ to F
([#10829](#10829))
([87df665](87df665))


### Bug Fixes

* add googleOther bot
([#10912](#10912))
([d56760a](d56760a))
* allow CORS requests for product image move
([#10920](#10920))
([967a47e](967a47e))
* attribute for product without new nutriscore data
([#10915](#10915))
([c413719](c413719))
* cosmetic changes for new Eco-Score grades
([#10921](#10921))
([6e7dbfa](6e7dbfa))
* Revert "fix: remove unused jquery-ui safe-active-element module
([#10708](#10708))"
([#10924](#10924))
([d290c54](d290c54))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants