Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reenable empty edits, bug #2318 #374 #2319

Merged
merged 1 commit into from
Sep 13, 2019
Merged

reenable empty edits, bug #2318 #374 #2319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/ProductOpener/Products.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,10 @@ sub store_product($$) {
my %diffs = %{$diffs};
if ((!$diffs) or (!keys %diffs)) {
$log->info("changes not stored because of empty diff", { change_ref => $change_ref }) if $log->is_info();
return 0;
# 2019/09/12 - this was deployed today, but it causes changes not to be saved
# compute_product_history_and_completeness() was not written to make sure that it sees all changes
# keeping the log and disabling the "return 0" so that all changes are saved
#return 0;
}

# 2018-12-26: remove obsolete products from the database
Expand Down