HTML Templatization of Product page #3846
Conversation
teolemon
added
the
Template::Toolkit
|
I'm testing on the dev server, one issue is that the same image is displayed for the front of the product, the ingredients, and the nutrition facts.
|
I'll look into this |
lib/ProductOpener/Display.pm
Outdated
| # obsolete product | ||
|
|
||
| if ((defined $product_ref->{obsolete}) and ($product_ref->{obsolete})) { | ||
|
|
||
| $template_data_ref->{product_ref_obsolete} = $product_ref->{obsolete}; |
There was a problem hiding this comment.
product_is_obsolete might be a better key name. $product_ref is just named like this since it's a reference variable.
| </div> | ||
|
|
||
| <div class="show-for-large-up large-4 xlarge-4 xxlarge-4 columns" style="padding-left:0"> | ||
| $html_image |
There was a problem hiding this comment.
Should this be a TT variable instead?
|
SonarCloud Quality Gate failed.
|
|
(closing this pull request and making a new one, for some reason github shows changes that are in fact already merged, and the test fails) |
Description:
HTML Templatization of Product page using Template::Toolkit
display_product() has been templatized
Related issues and discussion: #2416