-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed accessibility issue 1.1.1 #5071
Conversation
po/common/common.pot
Outdated
@@ -285,9 +285,9 @@ msgid "" | |||
"svg/donate-icon.svg\" alt=\"Donate to Open Food Facts\" /></" | |||
"a><p><<site_name>> is made by a non-profit association, independent from the " | |||
"industry. It is made for all, by all, and it is funded by all. You can " | |||
"support our work by <a href=\"https://world.openfoodfacts.org/donate-to-open-food-facts\">donating to Open Food Facts</a> and " | |||
"support our work by <a href=\"https://world.openfoodfacts.org/donate-to-open-food-facts\" style="text-decoration:underline;">donating to Open Food Facts</a> and " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have many other links like this one that are in the middle of other text. I'm thinking a better idea would be to change the CSS to underline links inside paragraph tags.
To discuss: #5074
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll start working on it.
po/common/en.po
Outdated
@@ -2507,6 +2507,10 @@ msgctxt "site_name" | |||
msgid "Open Food Facts" | |||
msgstr "Open Food Facts" | |||
|
|||
msgctxt "logo_site_name" | |||
msgid "Logo Open Food Facts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change it to "Open Food Facts logo"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, sure. You want "L" to be small? Should I open a separate pull request after changing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, small L.
You can keep this PR for the logo, but I think the other bug (the underlined links) should be done in another way, and moved to another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to split this into 2 PRs. The alt text for the logo is easy, but the underline links would probably be better done in another way: #5074
If we split it, then we can merge each PR independently.
Yes, it'll be better. I will open PR for each issue separately now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to split this into 2 PRs. The alt text for the logo is easy, but the underline links would probably be better done in another way: #5074
If we split it, then we can merge each PR independently.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description:
Issue 1.1.1: Changed the alt text for the logo.
Related issue #4640