fix: allow unchecking checked boxes in product edit form #6203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
requested changes
Dec 17, 2021
| @@ -96,12 +96,16 @@ | |||
|
|
|||
| <!--nutrient fieldset--> | |||
| <div class="fieldset" id="nutrition"><legend>[% lang('nutrition_data') %]</legend> | |||
| <!-- empty hidden checkbox with the same name so that the browser sends a value when the box is unchecked --> | |||
| <input type="hidden" name="no_nutrition_data" value="" /> | |||
There was a problem hiding this comment.
Hum this does not work for me !
If I check the box, this is not taken into account.
In Food.pm, in assign_nutriments_values_from_request_parameters, param("no_nutrition_data") is ''
|
Kudos, SonarCloud Quality Gate passed!
|
|
@alexgarel I updated the code to add a new hidden field, as you suggested if I remember correctly. |
alexgarel
reviewed
Jan 5, 2022
| elsif (defined param($checkbox . "_displayed")) { | ||
| $product_ref->{$checkbox} = ""; | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with my recent refactoring of the code to handle nutrition facts edit from the web product edit form and the API.
The issue is that when a checkbox is unchecked on a form, the browser actually does not send the field at all. So if the parameter is not there, we don't know if it's because it is not set on purpose (e.g. the API is changing something else), or the box is there but has been unset (through the web edit form).
The trick is to add a hidden field with the same name of the checkbox on the web form. That way we do get the hidden value if the box is unchecked, and the checked value if it is checked.