-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: start of additives panels #6270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
my $tagid = shift; | ||
|
||
my $properties_ref = shift; | ||
my $target_lcs_ref = shift; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is more than 3 or 4 arguments, shouldn't we use hash to pass arguments ?
I feel like this could help make the code a bit more readable (where we call such functions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use a hash, we lose the check on the number of arguments that Perl does at compile time. There isn't a very good way to have signatures in Perl unfortunately (there's an experimental "use experimental 'signatures';" and some modules).
Co-authored-by: Alex Garel <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Functional:
Knowledge panel API changes: