Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show 'we need your help' message for ingredients analysis only when needed #6342

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix: show 'we need your help' message for ingredients analysis only when needed #6342

merged 1 commit into from
Jan 26, 2022

Conversation

stephanegigandet
Copy link
Contributor

fixes #6341

@stephanegigandet stephanegigandet added the 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis label Jan 25, 2022
@stephanegigandet stephanegigandet requested a review from a team as a code owner January 25, 2022 17:45
@github-actions github-actions bot added Display Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Jan 25, 2022
@teolemon
Copy link
Member

  • If I open a product that's both in French and Ukrainian, the main language is used for recognition.
  • We're thus removing the ability to improve Ukrainian.
  • This message should ideally apply language by language

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit 9e001c1 into main Jan 26, 2022
@stephanegigandet stephanegigandet deleted the we-need-your-help branch January 26, 2022 08:28
@github-actions github-actions bot mentioned this pull request Jan 26, 2022
Merged
@stephanegigandet
Copy link
Contributor Author

"This message should ideally apply language by language"

The message is shown in context of the ingredients analysis results, so it's relevant only for the language used. Whether we should run the ingredients analysis on all available languages is a much more complex issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaiTon VaiTon VaiTon approved these changes

Assignees
No one assigned
Labels
Display 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
3 participants
@stephanegigandet @teolemon @VaiTon