-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow barcode and edit link in search results #6486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I would strongly recommend something visually more in line with other icons. The pencil looks like a knife.
- What about an image of the barcode ?
Hi @alexgarel, thanks for adding the possibility to display barcode and an edit button. I think it would be best not to include in the attributes options that affect only the website behaviour. The Smoothie app for instance is going to get those preferences, even though they won't be meaningful for Smoothie. It may also break some logic for the ranking of products according to attributes. The best place to add the website preferences would be in the user settings I think. We already have ways to display checkboxes that could be used for this feature. e.g. The drawback is that only logged in users would get those features, but those are contributors features anyway. Also in the current code, the radio buttons for the normal attributes are not displayed anymore. Regarding the icons, it would be best to reuse the existing edit icon we have (shown at top of product page) as @teolemon mentions. For the barcode icon, we use material design icons (or material design like icons), can you use this one, so that we can use it in the same way as the other icons? https://materialdesignicons.com/icon/barcode |
For the name of the section "Search preferences": I would just rename it to "Preferences", those 2 options affect the behaviour of all lists of product pages, not just search results. And later we could add other preferences. |
Autovivification bytes me !
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The problem of nounproject icons is that they are not CC-0 but CC-by. The two icons, I designed myself 😬 |
:) Using Inkscape? For the icons I create, I try to mimmick the Material design icons, with a 24x24 grid. |
I close this PR, I will do a new one. |
Description
Now in search preferences you can ask to have barcode and to have edit link.
It displays them in search results.
Screenshot
Then:
The pen links to edition.
Related issue(s) and discussion