feat: allow barcode and edit link in search results

[alexgarel]

Description

Now in search preferences you can ask to have barcode and to have edit link.
It displays them in search results.

Screenshot

Then:

The pen links to edition.

Related issue(s) and discussion

• fixes On web lists of products, add the product's barcode to its front picture, next to the Nutri-score and Eco-score #5994

[teolemon]

• I would strongly recommend something visually more in line with other icons. The pencil looks like a knife.
  • https://thenounproject.com/search/icons/?iconspage=1&q=barcode
  • https://thenounproject.com/search/icons/?iconspage=1&q=edit
• What about an image of the barcode ?

[stephanegigandet]

Hi @alexgarel, thanks for adding the possibility to display barcode and an edit button.

I think it would be best not to include in the attributes options that affect only the website behaviour. The Smoothie app for instance is going to get those preferences, even though they won't be meaningful for Smoothie. It may also break some logic for the ranking of products according to attributes.

The best place to add the website preferences would be in the user settings I think. We already have ways to display checkboxes that could be used for this feature. e.g.

The drawback is that only logged in users would get those features, but those are contributors features anyway.

Also in the current code, the radio buttons for the normal attributes are not displayed anymore.

Regarding the icons, it would be best to reuse the existing edit icon we have (shown at top of product page) as @teolemon mentions.

For the barcode icon, we use material design icons (or material design like icons), can you use this one, so that we can use it in the same way as the other icons? https://materialdesignicons.com/icon/barcode

[stephanegigandet]

For the name of the section "Search preferences": I would just rename it to "Preferences", those 2 options affect the behaviour of all lists of product pages, not just search results. And later we could add other preferences.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[alexgarel]

• I would strongly recommend something visually more in line with other icons. The pencil looks like a knife.

  * https://thenounproject.com/search/icons/?iconspage=1&q=barcode
  * https://thenounproject.com/search/icons/?iconspage=1&q=edit
  

  • What about an image of the barcode ?

The problem of nounproject icons is that they are not CC-0 but CC-by.
Or is there a specific page where to put those credits ?

The two icons, I designed myself 😬

[stephanegigandet]

The two icons, I designed myself grimacing

:)

Using Inkscape? For the icons I create, I try to mimmick the Material design icons, with a 24x24 grid.

[alexgarel]

I close this PR, I will do a new one.