Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: untranslated string for Smoothie #6492

Merged
merged 4 commits into from
Mar 17, 2022
Merged

fix: untranslated string for Smoothie #6492

merged 4 commits into from
Mar 17, 2022

Conversation

teolemon
Copy link
Member

What

  • Fix untranslated string for Smoothie

@teolemon teolemon changed the title Update ecoscore_unknown.tt.json Fix untranslated string for Smoothie Mar 16, 2022
@teolemon teolemon marked this pull request as ready for review March 16, 2022 16:56
@teolemon teolemon requested a review from a team as a code owner March 16, 2022 16:56
@teolemon teolemon linked an issue Mar 16, 2022 that may be closed by this pull request
Cannot find string "We could not compute the Eco-Score of this product as it is missing some data, could you help complete it?" #6471
Closed
@github-actions github-actions bot added 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products GitHub Actions Pull requests that update Github_actions code 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Mar 16, 2022
@teolemon teolemon changed the title Fix untranslated string for Smoothie Fix: untranslated string for Smoothie Mar 16, 2022
@teolemon teolemon changed the title Fix: untranslated string for Smoothie fix: untranslated string for Smoothie Mar 16, 2022
stephanegigandet
stephanegigandet approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you need to add the new string to en.po as well so that we can deploy without having to wait for the next crowdin merge

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon merged commit ffe58a2 into main Mar 17, 2022
@teolemon teolemon deleted the ecoscore-string-translation branch March 17, 2022 12:56
@github-actions github-actions bot mentioned this pull request Mar 17, 2022
Merged
@teolemon teolemon self-assigned this Apr 1, 2022
@teolemon teolemon added this to the V1.1.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@teolemon teolemon

Labels
🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products GitHub Actions Pull requests that update Github_actions code 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
V1.1.0
2 participants
@teolemon @stephanegigandet