Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improvements to Nutri-Score panel, remove extended Eco-Score panel #6748

Merged
merged 9 commits into from
May 10, 2022
Merged

feat: Improvements to Nutri-Score panel, remove extended Eco-Score panel #6748

merged 9 commits into from
May 10, 2022

Conversation

stephanegigandet
Copy link
Contributor

image

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner May 6, 2022 16:05
@stephanegigandet stephanegigandet added 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels May 6, 2022
@github-actions github-actions bot added Display Food.pm 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Tags 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org and removed 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore labels May 6, 2022
@stephanegigandet stephanegigandet changed the title Improvements to Nutri-Score panel, remove extended Eco-Score panel feat: Improvements to Nutri-Score panel, remove extended Eco-Score panel May 6, 2022
@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label May 9, 2022
alexgarel
alexgarel approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 37c76c1 into main May 10, 2022
@stephanegigandet stephanegigandet deleted the panels2 branch May 10, 2022 07:59
@alexgarel alexgarel mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Display Food.pm 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Tags 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
2 participants
@stephanegigandet @alexgarel