Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display_structured_response syntax #6948

Merged
merged 1 commit into from
Jun 24, 2022
Merged

fix: display_structured_response syntax #6948

merged 1 commit into from
Jun 24, 2022

Conversation

dipietroR
Copy link
Contributor

There seemed to be two of the same if statements:

if (defined $jsonp) {

So I combined the two

@dipietroR dipietroR requested a review from a team as a code owner June 23, 2022 16:41
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stephanegigandet
stephanegigandet approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit 525ad83 into main Jun 24, 2022
@stephanegigandet stephanegigandet deleted the display_structured_response-syntax branch June 24, 2022 09:06
@alexgarel alexgarel mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@dipietroR dipietroR

Labels
Display
Projects
No open projects
Outreachy 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipietroR @stephanegigandet