fix: explicit return statements in KnowledgePanels.pm

[dipietroR]

Used Perl::Critic to look for functions without return statements. I'm planning on making more PRs similar to this (for all of the other files) and then adding [Subroutines::RequireFinalReturn] to .perlcriticrc

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[stephanegigandet]

For reference, here is the rule: https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::RequireFinalReturn

I'm not sure if adding boilerplate return statement adds a lot of value, but I don't have a strong opinion against it.

[dipietroR]

I'm not sure if adding boilerplate return statement adds a lot of value, but I don't have a strong opinion against it.

I saw that it was being done in ded3dec so I assumed that we would like to add it in. Of course, if you don't want it done, I could stop and focus on a different rule that we may want added?

[stephanegigandet]

I saw that it was being done in ded3dec so I assumed that we would like to add it in. Of course, if you don't want it done, I could stop and focus on a different rule that we may want added?

Let's implement this rule as you have already done it for many files, as did @Ban3 . I'll approve all the related PRs and we can merge them.

But for the future rules to be added, let's discuss them first to see which ones we think will bring the most value. Could you for instance start an issue on GitHub to list a few new rules you think would be good candidates, with maybe 1 or 2 examples of the issues they would trigger in our code? Then we can review them and discuss the benefits.

[stephanegigandet]

Thank you!