Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deep nest limit 12 #7124

Merged
merged 1 commit into from
Jul 25, 2022
Merged

feat: Deep nest limit 12 #7124

merged 1 commit into from
Jul 25, 2022

Conversation

dipietroR
Copy link
Contributor

Adding [ControlStructures::ProhibitDeepNests] to .perlcriticrc and limiting nesting to 12 (12 appears to be the most amount of nesting done). I'm planning on adding this for now so that no one can add deeper nesting

@dipietroR dipietroR requested a review from a team as a code owner July 22, 2022 16:19
@dipietroR dipietroR mentioned this pull request Jul 22, 2022
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adding "[ControlStructures::ProhibitDeepNests]" to .perlcriticrc and
limiting nesting to 12
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dipietroR dipietroR merged commit 3607b5d into main Jul 25, 2022
@dipietroR dipietroR deleted the deep-nests branch July 25, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants