Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new misc facets for packagings with weights #7826

Merged
merged 2 commits into from
Dec 12, 2022
Merged

fix: new misc facets for packagings with weights #7826

merged 2 commits into from
Dec 12, 2022

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Dec 9, 2022 •
edited by teolemon
Loading

This PR adds new misc facets values so that we can track products that have packaging weight data.

  • en:packagings-with-weights
  • en:packagings-complete-with-weights
  • en:packagings-not-complete-with-weights
  • en:packagings-with-some-weights

@stephanegigandet stephanegigandet requested a review from a team as a code owner December 9, 2022 16:25
@github-actions github-actions bot added API v3 API WRITE WRITE API to allow sending product info and image 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests labels Dec 9, 2022
teolemon
teolemon approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@teolemon
Copy link
Member

teolemon commented Dec 9, 2022

Creating po_backend_run ... done

lib/ProductOpener/Packaging.pm: Begin Error Output Stream
lib/ProductOpener/Packaging.pm:822: assertion failure: '--assert-tidy' is set but output differs from input
lib/ProductOpener/Packaging.pm:
lib/ProductOpener/Packaging.pm: Input file length is 26689 chars
lib/ProductOpener/Packaging.pm: Output file length is 26691 chars
lib/ProductOpener/Packaging.pm: Files first differ at character 35 of line 694
lib/ProductOpener/Packaging.pm: 693: # Number of packaging components
lib/ProductOpener/Packaging.pm: <694: my $number_of_packaging_components = (defined $product_ref->{packagings...
lib/ProductOpener/Packaging.pm: >694: my $number_of_packaging_components
lib/ProductOpener/Packaging.pm: ^
lib/ProductOpener/Packaging.pm:
2

@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit ba763b6 into main Dec 12, 2022
@stephanegigandet stephanegigandet deleted the packaging-facets branch December 12, 2022 12:12
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
API v3 API WRITE WRITE API to allow sending product info and image 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @teolemon