Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /cgi/suggest.pl + tests #8004

Merged
merged 7 commits into from
Jan 19, 2023
Merged

fix: /cgi/suggest.pl + tests #8004

merged 7 commits into from
Jan 19, 2023

Conversation

stephanegigandet
Copy link
Contributor

I added tests for /cgi/suggest.pl as I'm working on taxonomy suggestions: #8002 and I want to move most of the suggest.pl code to a separate module.

There was a "use HTTP" missing that we need for the CORS refactor.

@stephanegigandet stephanegigandet requested a review from a team as a code owner January 17, 2023 11:33
@github-actions github-actions bot added ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🧪 tests labels Jan 17, 2023
@github-actions github-actions bot added the GitHub Actions Pull requests that update Github_actions code label Jan 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@alexgarel
Copy link
Member

As I saw your test, I was thinking : we even could generate documentation from those tests !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii GitHub Actions Pull requests that update Github_actions code 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants