Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: add support for multi Nutri-Score #8012

Merged
merged 3 commits into from
Jan 20, 2023
Merged

taxonomy: add support for multi Nutri-Score #8012

merged 3 commits into from
Jan 20, 2023

Conversation

teolemon
Copy link
Member

What

taxonomy: add support for multi Nutri-Score

image
https://hunger.openfoodfacts.org/logos?logo_id=3481825&count=50

@teolemon teolemon added the 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore label Jan 19, 2023
@github-actions github-actions bot added labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies and removed 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore labels Jan 19, 2023
@teolemon teolemon added the 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore label Jan 20, 2023
@stephanegigandet
Copy link
Contributor

How many products have this logo? It's not an official logo, so if it's only one brand with a few products, the pros of adding it may not outweight the cons (e.g. cluttering the taxonomy, translation work, labels suggestions in dropdowns etc.).

@teolemon
Copy link
Member Author

It's an official logo
Screenshot_20230120-100106.png

@stephanegigandet
Copy link
Contributor

It's an official logo !

OK, perfect then.

stephanegigandet
stephanegigandet reviewed Jan 20, 2023
View reviewed changes
taxonomies/labels.txt Outdated
@@ -19252,6 +19252,27 @@ nl:Nutriscore E
xx:Nutriscore E
label_categories:en: en:Nutrition Grades, en:Health

fr:Nutri-Score A et B
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put it in English instead, like the other Nutriscore entries? Without the "and" so that we don't need translations.

en:Nutriscore A/B
xx:Nutriscore A/B

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @stephanegigandet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant for all of them :) also with the identical xx:Nutriscore A/B so that it matches in all languages, and is shown in all languages without the en: prefix.

@github-actions github-actions bot removed the 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore label Jan 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon added the 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore label Jan 20, 2023
stephanegigandet
stephanegigandet approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit e066f7c into main Jan 20, 2023
@stephanegigandet stephanegigandet deleted the nutri-scores-complex branch January 20, 2023 15:47
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 20, 2023
Merged
@teolemon teolemon added 🚦 Nutri-Score and removed 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@teolemon teolemon

Labels
labels 🚦 Nutri-Score 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teolemon @stephanegigandet