fix: weighter->weigher, numbers vs strings, weights with units #8056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
API v3
API WRITE
github-actions
bot
added
the
🪶 Apache
github-actions
bot
added
the
📚 Documentation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #8056 +/- ##
==========================================
+ Coverage 44.68% 44.70% +0.01%
==========================================
Files 99 100 +1
Lines 20196 20212 +16
Branches 4636 4636
==========================================
+ Hits 9025 9035 +10
- Misses 10097 10103 +6
Partials 1074 1074
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alexgarel
reviewed
Feb 1, 2023
Comment on lines
+2122
to
+2125
| # We make a copy of numeric values so that Perl does not turn the value to a string when we concatenate it in the signature | ||
| my $number_of_units = $packagings_ref->{number_of_units}; | ||
| my $weight_measured = $packagings_ref->{weight_measured}; | ||
|
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 issues related to packaging weights:
Some functions were moved out from Food.pm to a new Units.pm in order to use them in Packaging.pm