Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: banner to promote the packaging operation #8167

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

stephanegigandet
Copy link
Contributor

This PR replaces the top donation banner by a banner to promote the packagings operation.

There are 2 variations: French and English. English is shown on all languages except French. I didn't put strings in Crowdin yet as we only have blog posts in French and English for now.

image

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner March 7, 2023 12:32
@github-actions github-actions bot added CSS product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Mar 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #8167 (7220235) into main (ba458d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8167   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files         102      102           
  Lines       20384    20384           
  Branches     4646     4646           
=======================================
  Hits         9552     9552           
  Misses       9684     9684           
  Partials     1148     1148           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanegigandet stephanegigandet merged commit a5f8023 into main Mar 7, 2023
@stephanegigandet stephanegigandet deleted the packagings-banner branch March 7, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants