Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hyphens for properties in folksonomy #8278

Merged

Conversation

benbenben2
Copy link
Collaborator

Related to issue 132 in folksonomy (openfoodfacts/folksonomy_api#132)

Hyphen ("-" symbol) should be allowed for the property in folksonomy.

Could not (or did not find how to) open folksonomy in local to check changes.

@benbenben2 benbenben2 requested a review from a team as a code owner March 31, 2023 22:16
@github-actions github-actions bot added the 🏷️ Folksonomy Project The Folksonomy project allows to add custom data to product, and model non food products. label Mar 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@benbenben2
Copy link
Collaborator Author

Related PR in folksonomy: openfoodfacts/folksonomy_api#134

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit dee45c2 into main Apr 11, 2023
@stephanegigandet stephanegigandet deleted the folksonomy_updated_possible_char_for_properties branch April 11, 2023 16:18
@CharlesNepote
Copy link
Member

Ok, feature is also deployed on Folksonomy engine API (it was the occasion to document production upgrade process).
See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ Folksonomy Project The Folksonomy project allows to add custom data to product, and model non food products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants