Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Add labels to labels.txt #8299

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

ArturLange
Copy link
Contributor

What

Added two labels found on Polish products

@github-actions github-actions bot added labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Apr 8, 2023
@ArturLange ArturLange changed the title Add labels to labels.txt [taxonomy] Add labels to labels.txt Apr 8, 2023
@ArturLange ArturLange changed the title [taxonomy] Add labels to labels.txt taxonomy: Add labels to labels.txt Apr 8, 2023
@benbenben2
Copy link
Collaborator

Good contribution @ArturLange.

If you want you can add the images as well as follows: download the images, convert them into .png, resize them so that the height is 90 pixels, rename the images (see links below).
Then, you add the images in "html/images/lang/pl/labels/" (you have to create those two last folders)
then, you can add in the taxonomy for labels:
image:pl:<name of your label>.<width>x90.png

and you can also add website, description, label_categories, country where this label an be found
website:pl:<url of the website>
description:en:<a word about the institute delivering this label or some other useful details>.
label_categories:en: en:Geographic label
country:en:Poland

Also, add for xx: to cover all languages. For example, for first one:

<en:Made in Poland
pl:Produkt polski
xx:Produkt polski

Here are some references that may guide you:

wiki doc:
https://wiki.openfoodfacts.org/Global_labels_taxonomy
https://wiki.openfoodfacts.org/Global_labels_taxonomy_logos

other doc:
https://support.openfoodfacts.org/help/en-gb/15-improving-open-food-facts-in-my-language-country/55-i-would-like-to-add-a-new-logo-for-labels

Here is an example how-to-add-labels:
https://github.com/openfoodfacts/openfoodfacts-server/pull/7920/files

@ArturLange ArturLange requested a review from a team as a code owner April 11, 2023 14:06
@ArturLange
Copy link
Contributor Author

@benbenben2 Thank you for the additional information.
I added things that you suggested.

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ArturLange !

@stephanegigandet stephanegigandet merged commit 263cd06 into openfoodfacts:main Apr 11, 2023
@ArturLange ArturLange deleted the polish_labels branch April 12, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants