-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow users to delete their own accounts #8548
Conversation
Looks good, thank you! From @alexgarel on Slack: "I would really have liked to have a separate DELETE button if possible, the delete checkbox with "save" is a bit difficult to understand I think ! |
Having a separate Delete button should be relatively easy to add through the template I think. |
I've just pushed a change to do this |
Codecov Report
@@ Coverage Diff @@
## main #8548 +/- ##
=======================================
Coverage 48.70% 48.70%
=======================================
Files 114 114
Lines 21412 21412
Branches 4789 4789
=======================================
Hits 10429 10429
Misses 9698 9698
Partials 1285 1285 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @john-gom Maybe we could put the "Danger zone" after the regular "Save" button: (maybe with an extra What do you think? |
Very easy to do but when I look at it I'm a bit concerned as the "call to action" for a form is typically at the bottom so I think having delete there could result in it being more likely to be clicked. Cosmetically I also prefer having the group boxes together rather than having the save button in-between them |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
What
Enable account deletion for regular users with suitable warnings
Screenshot
Related issue(s) and discussion