Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Tutorial about Account Creation in Pro platform #8577

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

MonalikaPatnaik
Copy link
Collaborator

What

Made relevant changes in templates\web\pages\user_form\user_form_page.tt.html for adding video beside the form.

Screenshot

image

for medium and smaller screens

image
image

Related issue(s) and discussion

@MonalikaPatnaik MonalikaPatnaik requested a review from a team as a code owner June 18, 2023 19:26
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👥 Users labels Jun 18, 2023
@@ -97,6 +99,17 @@
[% END %]

[% END %]
</form>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange, if you put </form> here, don't you get inputs, buttons etc. that are outside the <form>..</form> ?

@@ -97,6 +99,17 @@
[% END %]

[% END %]
</form>
</div>
<!-- show video about account creation in Pro Platform -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want the video displayed when we are not on the pro platform, is that the case?

@stephanegigandet
Copy link
Contributor

I just tested it, it looks good, but the video should be shown only on the pro platform, not on the public platform.

e.g. on the public platform:

image

Also we need to show the video only when users are creating their account. Currently the video is shown also when users are editing their account parameters:

image

And the video is also showing in the administrator section:

image

</label>
</div>
<!-- show video about account creation beside user form section-->
[% IF section.id != "professional" AND section.id != "contributor_settings" %]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the condition should probably be reversed: instead of showing the video when the section is not something and not something else, it should be shown only for the section we want it to be shown. Otherwise it will be shown in other sections (e.g. the administrator section, or any new section we add later)

@github-actions github-actions bot added the CSS label Jul 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@stephanegigandet stephanegigandet merged commit 7c6e53d into openfoodfacts:main Jul 25, 2023
13 checks passed
@MonalikaPatnaik MonalikaPatnaik deleted the add-video branch January 4, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👥 Users
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add tuto about account creating in the Pro platform
3 participants