-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Tutorial about Account Creation in Pro platform #8577
feat: Adding Tutorial about Account Creation in Pro platform #8577
Conversation
@@ -97,6 +99,17 @@ | |||
[% END %] | |||
|
|||
[% END %] | |||
</form> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's strange, if you put </form>
here, don't you get inputs, buttons etc. that are outside the <form>..</form>
?
@@ -97,6 +99,17 @@ | |||
[% END %] | |||
|
|||
[% END %] | |||
</form> | |||
</div> | |||
<!-- show video about account creation in Pro Platform --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the video displayed when we are not on the pro platform, is that the case?
I just tested it, it looks good, but the video should be shown only on the pro platform, not on the public platform. e.g. on the public platform: Also we need to show the video only when users are creating their account. Currently the video is shown also when users are editing their account parameters: And the video is also showing in the administrator section: |
</label> | ||
</div> | ||
<!-- show video about account creation beside user form section--> | ||
[% IF section.id != "professional" AND section.id != "contributor_settings" %] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the condition should probably be reversed: instead of showing the video when the section is not something and not something else, it should be shown only for the section we want it to be shown. Otherwise it will be shown in other sections (e.g. the administrator section, or any new section we add later)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
What
Made relevant changes in
templates\web\pages\user_form\user_form_page.tt.html
for adding video beside the form.Screenshot
for medium and smaller screens
Related issue(s) and discussion