Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compute ecoscore bonuses for all categories #8629

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Jun 28, 2023

This is to display packaging information for categories that don't have an Eco-Score, like sodas and spring water.

Fixes #8616 #8249

image

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8629 (e4ea0d1) into main (671ec3c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8629      +/-   ##
==========================================
- Coverage   48.79%   48.78%   -0.01%     
==========================================
  Files         114      114              
  Lines       21475    21475              
  Branches     4804     4804              
==========================================
- Hits        10478    10477       -1     
  Misses       9705     9705              
- Partials     1292     1293       +1     
Impacted Files Coverage Δ
lib/ProductOpener/Ecoscore.pm 75.91% <100.00%> (-0.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@alexgarel alexgarel merged commit 2be152e into main Jun 29, 2023
@alexgarel alexgarel deleted the ecoscore-bonus branch June 29, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🧪 tests
Projects
None yet
3 participants