Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update middle dot to keep catalan words #8690

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

benbenben2
Copy link
Collaborator

What

Updated stopwords for middle dot.
Some words in Catalan contain middle dot and should not be parsed.

Screenshot

Following screenshot shows middle dot without spaces around (first ingredient) and middle dot with spaces around (second ingredient).
middledot

Related issue(s) and discussion

@benbenben2 benbenben2 requested a review from a team as a code owner July 12, 2023 15:36
@github-actions github-actions bot added 🥗 Ingredients 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Jul 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #8690 (16d6ed5) into main (d0b3715) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8690   +/-   ##
=======================================
  Coverage   48.76%   48.76%           
=======================================
  Files         117      117           
  Lines       21816    21816           
  Branches     4859     4859           
=======================================
  Hits        10639    10639           
  Misses       9879     9879           
  Partials     1298     1298           
Impacted Files Coverage Δ
lib/ProductOpener/Ingredients.pm 90.80% <ø> (ø)
tests/unit/ingredients.t 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 6e05eb8 into main Jul 18, 2023
15 checks passed
@stephanegigandet stephanegigandet deleted the fix_middot_separator branch July 18, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mid dot is not processed
3 participants