Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove forgotten JS marker in nutrition_facts_table.tt.html #8720

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

alexgarel
Copy link
Member

When we copy code from perl to the template we forgot to remove the end of content marker (JS).

@alexgarel alexgarel requested a review from a team as a code owner July 24, 2023 07:38
@github-actions github-actions bot added Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Jul 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8720 (9f348a8) into main (b4edf99) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8720   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files         117      117           
  Lines       21882    21882           
  Branches     4869     4869           
=======================================
  Hits        10676    10676           
  Misses       9903     9903           
  Partials     1303     1303           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups

@stephanegigandet stephanegigandet merged commit 2d579bb into main Jul 24, 2023
15 checks passed
@stephanegigandet stephanegigandet deleted the fix-remove-js-marker branch July 24, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants