Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: Taxonomy update (mostly Polish) - 2 #8771

Merged
merged 32 commits into from
Aug 7, 2023
Merged

taxonomy: Taxonomy update (mostly Polish) - 2 #8771

merged 32 commits into from
Aug 7, 2023

Conversation

stephanegigandet
Copy link
Contributor

I will try to fix merge conflicts and tests for @ArturLange 's PR #8663

ArturLange and others added 28 commits April 26, 2023 20:39
@ArturLange
Add new genuses, species and standarize
4e0d467
@ArturLange
Improve taxonomy, add tests
b12c0b7
@ArturLange
Replace unnecessary entries with xx:
73f1ded
@stephanegigandet
Merge branch 'main' into taxonomy_mushrooms
bccf8d5
@ArturLange
Fix lint and small errors
c336bce
@ArturLange
Merge remote-tracking branch 'origin' into taxonomy_mushrooms
f3745fd
@benbenben2
Merge branch 'main' into taxonomy_mushrooms
e15d54c
@ArturLange
Fix expected test results
d402440
@ArturLange
Merge branch 'main' into taxonomy_mushrooms
4e55e89
@ArturLange
Merge branch 'main' into taxonomy_mushrooms
55ffb0c
@ArturLange
Implement preparsing for Polish, adjust tests
db565da
@ArturLange
Add more tests
d5eb9b1
@ArturLange
Improve ingredients taxonomy
869a442
@ArturLange
Add ignored string and ingredients
10d5024
@ArturLange
Fix lint
a6ad323
@ArturLange
taxonomy: add ingredients
ed24df1
@ArturLange
Update taxonomies and regexes
8464291
@ArturLange
Merge branch 'main' into pl-taxonomy-kasza
1fadcdd
@ArturLange
Update test results
020dcbb
@ArturLange
Add enumerations
6ef26f4
@ArturLange
Merge branch 'main' into pl-taxonomy-kasza
f1d9e3d
@ArturLange
Update taxonomies
4fefb1f
@ArturLange
Merge branch 'main' into pl-taxonomy-kasza
f68e6b7
@ArturLange
Merge branch 'main' into pl-taxonomy-kasza
6f7db1f
@ArturLange
Fix lint
d01d339
@ArturLange
Merge branch 'main' into pl-taxonomy-kasza
5a587b1
@ArturLange
Add expected test results from main branch
cee0a1a
@stephanegigandet
Merge branch 'main' into pl-taxonomy-kasza
35dbbd6
@stephanegigandet stephanegigandet requested a review from a team as a code owner August 1, 2023 09:23
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 additives 🥜 Allergens categories 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling labels 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients - processing labels Aug 1, 2023
@ArturLange
Copy link
Contributor

Thank you!
Unfortunately I was unable to make tests work

benbenben2
benbenben2 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve already, but look at the comment.

taxonomies/ingredients_processing.txt Outdated Show resolved Hide resolved
taxonomies/nutrient_levels.txt Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2
Copy link
Collaborator

Kudos to both of you @stephanegigandet and @ArturLange 👍

@benbenben2 benbenben2 merged commit bf112bd into main Aug 7, 2023
14 checks passed
@benbenben2 benbenben2 deleted the pl-taxonomy-kasza-2 branch August 7, 2023 18:57
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Aug 7, 2023
Merged
@alexgarel alexgarel mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbenben2 benbenben2 benbenben2 approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🧪 additives 🥜 Allergens categories 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🥗 Ingredients - processing 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients labels 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests 🧪 unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanegigandet @ArturLange @benbenben2