Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse origins (ingredient from origin) in German, Italian and Spanish #8938

Merged
merged 1 commit into from
Sep 2, 2023
Merged

fix: parse origins (ingredient from origin) in German, Italian and Spanish #8938

merged 1 commit into from
Sep 2, 2023

Conversation

stephanegigandet
Copy link
Contributor

fixes #8936

@stephanegigandet stephanegigandet requested a review from a team as a code owner September 1, 2023 15:58
@github-actions github-actions bot added 🥗 Ingredients 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

CharlesNepote
CharlesNepote approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@CharlesNepote CharlesNepote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

benbenben2
benbenben2 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@benbenben2 benbenben2 merged commit 1c416ee into main Sep 2, 2023
14 checks passed
@benbenben2 benbenben2 deleted the aus-spanien branch September 2, 2023 14:05
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Sep 2, 2023
Merged
@teolemon teolemon added the German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesNepote CharlesNepote CharlesNepote approved these changes

@benbenben2 benbenben2 benbenben2 approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingredients parsing: "aus XXXX" in German is not recognized
4 participants
@stephanegigandet @CharlesNepote @benbenben2 @teolemon