Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add xx: entries to all additives #8939

Merged
merged 11 commits into from
Sep 5, 2023
Merged

fix: add xx: entries to all additives #8939

merged 11 commits into from
Sep 5, 2023

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Sep 1, 2023

What

Part of

@stephanegigandet stephanegigandet requested a review from a team as a code owner September 1, 2023 16:57
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 additives labels Sep 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #8939 (28510f6) into main (be246a1) will decrease coverage by 3.45%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8939      +/-   ##
==========================================
- Coverage   46.04%   42.60%   -3.45%     
==========================================
  Files          64       61       -3     
  Lines       19792    19480     -312     
  Branches     4791     4748      -43     
==========================================
- Hits         9113     8299     -814     
- Misses       9494    10043     +549     
+ Partials     1185     1138      -47     

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/snippets/add_xx_entry_to_additives.pl Outdated Show resolved Hide resolved
@alexgarel alexgarel enabled auto-merge (squash) September 4, 2023 13:15
@@ -31,13 +31,24 @@

while (my $line = <STDIN>) {

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning ⚠️

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge tag issue

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit 2978eed into main Sep 5, 2023
13 checks passed
@alexgarel alexgarel deleted the xx-additives branch September 5, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non vegan additives should trigger non vegan status
5 participants