feat: add support for product quantity and packaging weights in search graphs #8963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Translations
|
Added very basic support for NOVA + Eco-Score score (which seems to go above 100, maybe we should cap it)
|
alexgarel
approved these changes
Sep 6, 2023
| return ($title, $unit, $unit2, $allow_decimals); | ||
| } | ||
|
|
||
| sub display_scatter_plot ($graph_ref, $products_ref) { |
Co-authored-by: Alex Garel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #8963 +/- ##
==========================================
+ Coverage 38.16% 46.01% +7.84%
==========================================
Files 59 64 +5
Lines 19079 19818 +739
Branches 4653 4798 +145
==========================================
+ Hits 7282 9119 +1837
+ Misses 10720 9512 -1208
- Partials 1077 1187 +110
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Alex Garel <[email protected]>
teolemon
approved these changes
Sep 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in last packagings call: now that we have packaging weights, we could create graphs (histograms or scatter plots) using the packaging weights, so that it's easy to see distributions and view the corresponding products.
Part of