Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use images subdomain for images #9009

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

hangy
Copy link
Member

@hangy hangy commented Sep 16, 2023

What

Use the image subdomain in more places where the current subdomain is currently used.

Related issue(s) and discussion

@hangy hangy requested a review from a team as a code owner September 16, 2023 12:10
@hangy hangy self-assigned this Sep 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a0e358e). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #9009   +/-   ##
=======================================
  Coverage        ?   46.12%           
=======================================
  Files           ?       64           
  Lines           ?    19850           
  Branches        ?     4795           
=======================================
  Hits            ?     9155           
  Misses          ?     9528           
  Partials        ?     1167           
Files Changed Coverage Δ
lib/ProductOpener/Display.pm 11.22% <ø> (ø)
lib/ProductOpener/Images.pm 12.73% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 273676f into main Sep 19, 2023
14 checks passed
@stephanegigandet stephanegigandet deleted the fix-product-images-domain branch September 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants